Auto-indent on newline broken in 1.0.2

[martinpllu]

Auto-indent on newline works in 1.0.1 but is broken in 1.0.2.

To test, I'm opening a new file (Command-N) and typing a line that starts with a tab. When I press return I expect the next line to have the same indentation. The behaviour is as expected on 1.0.1 but there is no indentation on the next line in 1.0.2.

I tested the behaviour by installing 1.0.1 and 1.0.2 packages from https://github.com/atom/atom/releases. I'm using Mac OSX Yosemite and vanilla installs of Atom with no third party plugins.

Cheers,

Martin

[feifanzhou]

👍

[aoifefahey]

I can confirm the same issue on Windows Server 2008 R2 Standard. When creating a new file, auto-indent works on 1.01, but does not work on 1.02. If I set the language to SQL in 1.02 auto-indent works. The issue persists after I've saved the new file, unless the file triggers the SQL highlighting.

This issue persists in 1.02 with every package disabled. Auto-indent continues to work in 1.01 with every package disabled.

[maxbrunsfeld]

/cc @svanharmelen

[svanharmelen]

@maxbrunsfeld @martinpllu I'll have a look... It seems to give this result only when no language is selected (so when using plain text). As soon as I select a language (any language that is) it works as expected.

[aoifefahey]

@svanharmelen I've tested all of the langauges on my system. It appears the issue occurs when the language grammer doesn't have an increase or decrease indent grammar rule. Auto-indent is broken when using CSS, but works with SQL, HTML, etc.

Here is an example of the grammar rule from Language-SQL:

'increaseIndentPattern': '^\\s*(create|grant|insert|delete|update)\\b|\\((?!.*\\))'
'decreaseIndentPattern': '^\\s*\\)(?!=.*\\()'

Here is an example from the grammar rule from Language-HTML:

'increaseIndentPattern': '(?x)
      <(?!\\?|(?:area|base|br|col|frame|hr|html|img|input|link|meta|param)\\b|[^>]*/>)
      ([-_\\.A-Za-z0-9]+)(?=\\s|>)\\b[^>]*>(?!.*</\\1>)
      |<!--(?!.*-->)
      |<\\?php.+?\\b(if|else(?:if)?|for(?:each)?|while)\\b.*:(?!.*end\\1)
      |\\{[^}"\']*$
    '
    'decreaseIndentPattern': '(?x)
      ^\\s*
      (</(?!html)
        [-_\\.A-Za-z0-9]+\\b[^>]*>
        |-->
        |<\\?(php)?\\s+(else(if)?|end(if|for(each)?|while))
        |\\}
      )'

Language-text and Language-CSS do not have indent rules in their grammar, and I suspect that is why they are breaking.

Quick edit:
You removed the following lines from src/selection.coffee in the following commit: eaf814e
Perhaps those lines were what lead to an auto-indent when the grammar didn't have an indent rule? Pardon my ignorance if I'm completely off base, I haven't looked at any of atom's code until now.

-      currentIndentation = @editor.indentationForBufferRow(newBufferRange.start.row)       
       @editor.autoIndentBufferRow(newBufferRange.end.row, preserveLeadingWhitespace: true, skipBlankLines: false)             @editor.autoIndentBufferRow(newBufferRange.end.row, preserveLeadingWhitespace: true, skipBlankLines: false)
-      if @editor.indentationForBufferRow(newBufferRange.end.row) < currentIndentation      
-        @editor.setIndentationForBufferRow(newBufferRange.end.row, currentIndentation)

[svanharmelen]

@DylanFahey yes, I was just looking at the same thing... But those lines (https://github.com/atom/atom/blob/master/src/language-mode.coffee#L254-L255) were already in there before as well: eaf814e#diff-7d7c3b2f436032f702341d66de00c841R254 Albeit in a slightly different syntax.

[svanharmelen]

@DylanFahey that indeed has something to do with it 😉

PR #8048 fixes (as far as I can tell and have tested) the problem without falling back to the old behaviour.

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. If you can still reproduce this issue in Safe Mode then please open a new issue and fill out the entire issue template to ensure that we have enough information to address your issue. Thanks!