This repository was archived by the owner on Dec 15, 2022. It is now read-only.
More fixes to attribute value autocompletion#63
Merged
Conversation
added 2 commits
April 29, 2017 00:13
The word boundary method used in the specs reports =", but the method used in ac+ is much more sophisticated and returns an empty string in the same scenario. Manually adjust the prefix so that we test real-life scenarios.
Contributor
Author
|
Ugh. <button type="'|'"will throw. |
Contributor
Author
|
Attribute value completion needs a more robust prefix, but that can be done in a separate PR. |
Contributor
Author
|
Well, now that the last commit b0a0e29 adds the existence operator to the line that was throwing every time we attempted to autocomplete something incorrectly, this should now be good to merge. The other commits just fix and improve some logic so we attempt to autocomplete values only when necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Hopefully this will be the last batch of fixes. #62 caused value autocompletion to stop working entirely. Specs didn't catch it for some reason (probably because of a different prefix being sent). I'll try to tweak the specs so that they cover more real-life scenarios and do some extra testing to make sure everything's working as expected.
Alternate Designs
Instead of manually adjusting the prefix in the specs, the specs could call the internal method that ac+ uses to get the actual prefix.
Benefits
Value autocompletion will work again.
Possible Drawbacks
Regressions. I'll be testing this more though.
Applicable Issues
None.