This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix performance regression when there is no >#315
Merged
Conversation
Contributor
Author
|
Darn. There's still some catastrophic backtracking, even with this new regex. |
winstliu
changed the title
Contributor
Author
|
Ok, I believe this should fix things. One regression: multiline self-closing tags are not recognized as self-closing tags. |
Contributor
|
@50Wliu Do you think we can ship this even with the issue of multiline self-closing tags? |
Contributor
Author
|
Since the self-closing tags highlighting isn't even on atom/atom master yet, I think it's safe to merge this and create another followup issue about multiline self-closing tags. |
Ben3eeE
changed the title
Contributor
|
@ungb I have tested this for a while and it looks good to me. I added it to your TODO. Can you merge this after you have tested it? |
Contributor
|
I've tested this as well. Merging! thanks @50Wliu and @Ben3eeE for taking this on! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This works, but I'm not sure if it introduces other regressions (unlikely, but I'm not the one to say 😊). It would also be nice to change this to use scopes instead of using word boundaries to find tag boundaries.
Fixes #314