Remap/remove keybindings to avoid i8n key conflicts #822

Merged
merged 2 commits into from Nov 30, 2016

Projects

None yet

2 participants

@damieng
Member
damieng commented Nov 30, 2016 edited

As part of our efforts to support international keyboards we are remapping various ctrl-alt keybindings. This change makes the following adjusments to find and replace keybindings on Windows and Linux only;

  • show-replace keybinding is removed
  • toggle-case-option changes to ctrlshiftc
  • toggle-selection-option keybinding is removed
  • toggle-whole-word-option keybinding is removed
@damieng damieng Remap shortcuts to avoid i8n keyboard conflicts
25ba263
@damieng damieng referenced this pull request in atom/atom-keymap Nov 30, 2016
Closed

Problem with polish (programmer) keyboard #187

@maxbrunsfeld
Contributor
maxbrunsfeld commented Nov 30, 2016 edited

Should we just remove some of these bindings on windows, and let people bind them themselves if they want?

Like, what about keeping only ctrl-shift-c for case sensitivity?

@damieng
Member
damieng commented Nov 30, 2016

I'm always up for less default keybindings hence the removal of show-replace (you can't use replace without find anyway).

I like the idea of just having case-sensitive. Do you want to keep all the mac bindings?

@maxbrunsfeld
Contributor

I think we should keep the mac ones.

@damieng damieng Remove bindings for selection/word toggles on win/linux
4f1d885
@damieng damieng changed the title from Remap shortcuts to avoid i8n keyboard conflicts to Remap/remove keybindings to avoid i8n key conflicts Nov 30, 2016
@damieng damieng merged commit 93ae854 into master Nov 30, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@damieng damieng deleted the dg-replace-ctrl-alt-shortcuts branch Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment