Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Comments

Remap/remove keybindings to avoid i8n key conflicts#822

Merged
damieng merged 2 commits intomasterfrom
dg-replace-ctrl-alt-shortcuts
Nov 30, 2016
Merged

Remap/remove keybindings to avoid i8n key conflicts#822
damieng merged 2 commits intomasterfrom
dg-replace-ctrl-alt-shortcuts

Conversation

@damieng
Copy link
Contributor

@damieng damieng commented Nov 30, 2016

As part of our efforts to support international keyboards we are remapping various ctrl-alt keybindings. This change makes the following adjusments to find and replace keybindings on Windows and Linux only;

  • show-replace keybinding is removed
  • toggle-case-option changes to ctrlshiftc
  • toggle-selection-option keybinding is removed
  • toggle-whole-word-option keybinding is removed

@maxbrunsfeld
Copy link
Contributor

maxbrunsfeld commented Nov 30, 2016

Should we just remove some of these bindings on windows, and let people bind them themselves if they want?

Like, what about keeping only ctrl-shift-c for case sensitivity?

@damieng
Copy link
Contributor Author

damieng commented Nov 30, 2016

I'm always up for less default keybindings hence the removal of show-replace (you can't use replace without find anyway).

I like the idea of just having case-sensitive. Do you want to keep all the mac bindings?

@maxbrunsfeld
Copy link
Contributor

I think we should keep the mac ones.

@damieng damieng changed the title Remap shortcuts to avoid i8n keyboard conflicts Remap/remove keybindings to avoid i8n key conflicts Nov 30, 2016
@damieng damieng merged commit 93ae854 into master Nov 30, 2016
@damieng damieng deleted the dg-replace-ctrl-alt-shortcuts branch November 30, 2016 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants