This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Remap/remove keybindings to avoid i8n key conflicts#822
Merged
Conversation
Contributor
|
Should we just remove some of these bindings on windows, and let people bind them themselves if they want? Like, what about keeping only |
Contributor
Author
|
I'm always up for less default keybindings hence the removal of show-replace (you can't use replace without find anyway). I like the idea of just having case-sensitive. Do you want to keep all the mac bindings? |
Contributor
|
I think we should keep the mac ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of our efforts to support international keyboards we are remapping various ctrl-alt keybindings. This change makes the following adjusments to find and replace keybindings on Windows and Linux only;
show-replacekeybinding is removedtoggle-case-optionchanges to ctrlshiftctoggle-selection-optionkeybinding is removedtoggle-whole-word-optionkeybinding is removed