Fuzzy finder is not ignoring .gitignore files

[coltonw]

I have the "Exclude VCS Ignored Paths" setting on but fuzzy finder is NOT excluding them. My .gitignore looks like the following:

/webapp
/target
node_modules
shorthash.txt
/.idea/workspace.xml

Currently running latest Atom version which is using fuzzy finder 0.70.0

[izuzak]

Fuzzy finder is correctly excluding files for me.

Can you share which steps exactly reproduce the problem for you, starting from a git clone command which clones a repository containing the project and the .gitignore file? Also, please clarify which version of Atom you're using (atom -v) and which OS. (The latest version might be the latest released version, or the latest version built from master of atom/atom, and you didn't make that clear.)

[ismyrnow]

I'm experiencing the same on Windows 8.1, with version 0.187.0. I have confirmed that "Exclude VCS Ignored Paths" is checked in my settings. My gitignored files are greyed out in the tree view, but not ignored by fuzzy finder.

Steps to reproduce:

1. git clone git@github.com:ismyrnow/Leaflet.groupedlayercontrol.git
2. npm install
3. atom --safe .
4. ctrl+t then type package.json. You should only see one result.

[izuzak]

You should only see one result.

Just followed the instructions and I indeed do see only one result -- the top-level package.json.

Can you clarify what you see, @ismyrnow?

[ismyrnow]

Sorry. I see all of the package.json files in all subdirectories, including node_modules, which should be ignored.

[izuzak]

Thanks for helping investigate this. Does this happen for any project and any ignore pattern, or just for this project and this pattern? Can you try changing the pattern in the .gitignore file to cover bower.json and see if that is handled correctly, for example?

[ismyrnow]

It happens for every project. I attempted a handful of other ignore patterns in my .gitignore file, including node_modules, node_modules\, package.json, and bower.json to name a few. When I save my .gitignore file and hit ctrl+t, it briefly says it is reindexing, then it shows all of the files as before.

It looks like it is ignoring all of the .gitignore patterns, regardless of how they are typed.

[coltonw]

I am having the same behavior as @ismyrnow on Windows 7 and am also using atom version 0.187.0. My coworker is seeing the same issues on a Mac.

Sorry for not being clearer initially!

[Jaeiya]

I am also having the same issue. Windows 8.1. Atom 0.187.0. fuzzy-finder 0.70.0.

The treeview obeys the VCS setting and hides all ignored files in the tree view, the fuzzy-finder however, does not.

[darylng]

I have the same issue. Windows 8.1, Atom 0.188.0 fuzzy-finder 0.72.0 and excludeVcsIgnoredPaths: true

[darylng]

It appears to me that on my system in the code below, repo.getWorkingDirectory() returns path using / while this.rootPath uses \

if ((repo != null ? repo.getWorkingDirectory() : void 0) === this.rootPath) {
    this.repo = repo;
}

[nruth]

I'm also getting this on my Mac.

atom -v
0.188.0

and fuzzy-finder is 0.72.0

Again, git ignores the files correctly and Atom is greying out the directories, but fuzzy finder is searching my tmp files and whatnot.

All my ignored file strings in atom are default or empty, I rely on the gitignore files doing everything. I have quite a lot of packages installed though, so should figure out how to test without them.

I've set up a minimal sample project where it happens:

git clone git@github.com:nruth/atom-fuzzy-finder-issue-demo.git 
cd atom-fuzzy-finder-issue-demo
mkdir tmp
touch tmp/shouldntseemee.txt
mkdir frontend/tmp
touch frontend/tmp/shouldntseeme.txt
git status
atom .

git status should say working directory clean.
Open in atom and try fuzzy finder, I get this:

[filimon-danopoulos]

I am also experiencing this on my Windows 8.1 machine.
I am running Atom 0.188.0 and fuzzy-finder 0.72.0.

tree-view is handling ignored files correctly. I will try it from my Linux machine later and see if the issue is present there too.

[mjhm]

Also experiencing the problem. mac osx, atom 0.189.0, fuzzy-finder 0.72.0

[izuzak]

@nruth I just tried reproducing this with your instructions in #89 (comment), but wasn't able to. I'm using Atom 0.193.0-bcb8ca4 on OSX 10.10.2, and here's what I'm seeing in Atom:

Just to make sure -- you do have the "Exclude VCS Ignored Paths" config option enabled?