Bug with git diff replicating

[VB-is-Terrible]

Prerequisites

• Have you tried to reproduce the problem in Safe Mode? Yes
• Have you followed all applicable steps in the debugging guide? Yes
• Have you checked the FAQs on the message board for common solutions? It's a new bug, no solutions exist
• Have you checked that your issue isn't already filed? Yes

Discuss topic

Description

The git diff panel gets copied to the active directory on some key strokes. See images.

Steps to Reproduce

Prerequisites: Have a unstaged/uncommited change in git

1. Have at least two panes open
2. Open git tab open
3. Open a git diff panel in one of the panes
4. Switch to a different
5. [Keyboard] Ctrl+S (Alt-tab also works)

Expected behavior:

Nothing

Actual behavior:

The git diff panel copies into the active pane

Reproduces how often:

100%

Versions

Atom 1.20-beta3 x64 on Ubuntu 17.04
Atom 1.20.0-beta5 on Ubuntu 16.04

Additional Information

Before:

[Alt-tab out, Alt-tab in]

No errors in console

There isn't anything abnormal in the keybinding resolver
Crtl+s only contains core:save
Alt-tab isn't recognized by the resolver (Probably intercepted by my compositor)

---

Some details from @rsese:

With the Git panel enabled:

1. Open some file in a repo and split the pane right.
2. Save a change to create an unstaged change.
3. Click the unstaged change in the Git panel to open the diff view.
4. Click in the pane that doesn't have the diff view in it.
5. alt-tab out of Atom and then back into Atom.

The diff view is then duplicated into the pane that didn't have the diff view originally.

GIF-ment:

Can't reproduce on macOS 10.12.6 so tagging as Linux for now.

[rsese]

Thanks for moving this over from Discuss 👍

I remember I had reproduced with 1.20.0-beta5 using alt-tab but I just tried to reproduce again with the latest beta 1.21.0-beta0 but couldn't reproduce anymore on Ubuntu 16.04.

Can you confirm if you still see this in 1.21.0-beta0?

[rsese]

Sorry tried again and can reproduce in 1.21.0-beta0 - I think when I tried laste time, I had double clicked on the Unstaged Changes tab for the file I changed (so the tab title wasn't italicized). In that case, I can't reproduce.

If I just click an unstaged change in the Git panel and then click the other pane before alt-tab-ing, then I can reproduce:

Thanks again for the report 🙇

[kuychaco]

Thanks for the report! This is a duplicate of #1163, and was closed in #1165. The fix is currently on dev and will reach beta/stable as part of v1.22

[rsese]

ahhh I missed that one, thanks @kuychaco 🙇