Unable to push on Windows

[winstliu]

module.js:472
    throw err;
    ^

Error: Cannot find module 'C:\Users\user\Documents\GitHub\github\node_modules\dugite\build\lib\index.js\git\bin\git'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object. (C:\Users\user\AppData\Local\Temp\github-XU5JyE\git-credential-atom.js:7:22)
    at Object. (C:\Users\user\AppData\Local\Temp\github-XU5JyE\git-credential-atom.js:278:3)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
error: cannot spawn /C/Users/user/AppData/Local/Temp/github-XU5JyE/git-askpass-atom.sh: No such file or directory
fatal: could not read Username for 'https://github.com': terminal prompts disabled

Versions

Atom Version (atom --version): 1.18.0-dev-8eaafc23c

GitHub Package Version (git --git-dir ~/.atom/packages/github/.git rev-parse head): 06c35e9

Windows 10 x64, Creators Update

[BinaryMuse]

Likely related to #640, specifically 4266655 though I'm unsure how it ever worked...?

[smashwilson]

Ahhhh, yep. ATOM_GITHUB_DUGITE_PATH is meant to be the path to require the dugite module, not the git binary within.

This does tell me that we need tests that exercise the actual bin/ scripts to catch regressions like these. I guess the existing ones mock it away? 🤔

[smashwilson]

Fixed in #717 and tested in #719. 🤸‍♂️