Stage All button not work on huge commits

[khaninejad]

Description

When I want to commit huge file it not work,(more than 700 files)
Steps to Reproduce

I have files to commit
2.
Click on git stage
3.
Click on stage all button
4.
nothing happen

Expected behavior:
All file moved to staged changes

Actual behavior:
button or function not work

Reproduces how often:
with big commits(more than 700 files)
Versions

1.18.0 x64 Windows
Additional Information

I use gitlab

---

Steps to repro from @rsese:

1. git clone https://github.com/atom/atom atom-tmp
2. cd atom-tmp
3. mv .git .git-back
4. atom --safe .
5. Enable the Git panel
6. Click "Create repository"
7. Click "Stage All"

[rsese]

Click on stage all button
4.
nothing happen

Thanks for the report! Just to confirm, does Atom hang at this point and you can't do anything else?

[rsese]

Oh also maybe /cc #958 and #959?

[khaninejad]

@rsese no, it does not hang. everything work and also button is clickable.

[ninthart]

Yep, I have this issue too. Click the Stage All button and nothing happens, except for a temporary rise in Atom's CPU usage. There's no crash, but everything slows down in that instance of the editor (if I switch to another project in another window/tab, everything's fine).

I'm on Mac OS X Sierra 10.12.5

Atom : 1.18.0
Electron: 1.3.15
Chrome : 52.0.2743.82
Node : 6.5.0

[rsese]

@khaninejad @ninthart - if you open dev tools (Window: Toggle Dev Tools from the command palette) are there any errors in console?

[ninthart]

@rsese Nope, nothing.

[khaninejad]

@rsese nothing either

[rsese]

Thanks for confirming @ninthart @khaninejad - can you try enabling diagnostics for the GitHub package and share what you see in console after trying to stage all (feel free to redact any private details)? The setting is at Settings > Packages > GitHub > Git Diagnostics.

[ninthart]

@rsese OK, I've just tried this, but on clicking the stage all button, absolutely nothing is written to the console, even after turning on Git Diagnostics. I've confirmed that the Diagnostics are on, see below:

git:git rev-parse --resolve-git-dir /Users/XXXXX/Dropbox\ \(Personal\)/work/htdocs/site_directory/.git in /Users/XXXXX/Dropbox\ \(Personal\)/work/htdocs/site_directory
<embedded>:175975 git:git rev-parse --resolve-git-dir /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory/.git in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git config atomGithub.historySha in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git config atomGithub.historySha in /Users/XXXXX/Dropbox\ \(Personal\)/work/htdocs/site_directory
<embedded>:175975 git:git config atomGithub.currentRemote in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git config --local --get-regexp ^remote\..*\.url$ in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git for-each-ref --format=%(refname:short) refs/heads/** in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git log --pretty=%H%x00%B%x00 --no-abbrev-commit -1 HEAD in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git status --porcelain=v2 --branch --untracked-files=all --ignore-submodules=dirty -z in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git config branch.master.remote in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory
<embedded>:175975 git:git config branch.master.atomPrUrl in /Users/XXXXX/Dropbox (Personal)/work/htdocs/site_directory

[rsese]

Hmmm, do either of you see the same behavior with a simple test repo?

@khaninejad from your report you mention you see this when you have a lot of changes, but can you confirm if you have only a small number of changes if you see the same behavior?

[khaninejad]

@rsese

Hmmm, do either of you see the same behavior with a simple test repo?

Yes

@khaninejad from your report you mention you see this when you have a lot of changes, but can you confirm if you have only a small number of changes if you see the same behavior?

No with small changes everything works fine.

[rsese]

@khaninejad did you have any output with diagnostics enabled?

[khaninejad]

@rsese yes but it is nothing on output.

[khaninejad]

Yes, I did

On Thu, Jun 29, 2017 at 12:12 AM Robert Sese ***@***.***> wrote: @khaninejad <https://github.com/khaninejad> did you have any output with diagnostics enabled? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#960 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEM1FPi6gvyRq_IjbYJ3OHO1NdqdYpBEks5sIqy-gaJpZM4OAd4N> .

-- Sent from iPhone