This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Trick electron-link #1304
Merged
Trick electron-link #1304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smashwilson
force-pushed
the
trick-electron-link
branch
from
ac60358 to
dcf4722
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fool electron-link into skipping the
require()for electron-devtools-installer, which is installed as a dev dependency and unavailable when we're bundled.installReactDevTools()is only called in dev mode, so this should be fine. If we do care about being able to install devtools while we're bundled we'd have to move electron-devtools-installer to be a non-dev dependency.