This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Make ListSelections immutable #1421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To lay some groundwork for converting
StagingView
to React, I'm converting ourListSelection
models to be immutable.Rather than updating the selection in-place:
Mutation methods return a new ListSelection with the modification made:
This should make manipulating selection models in
setState()
calls safer and more ergonomic, because we can use its updater method variant:ListSelection
immutableCompositeListSelection
immutableStagingView
to use itsCompositeListSelection
immutably