Mass dependency upgrade

.babelrc

@@ -7,7 +7,6 @@
     "chai-assert-async",
     "transform-object-rest-spread",
     "transform-es2015-modules-commonjs",
-    "transform-async-to-generator",
     "transform-decorators-legacy", // must come before class-properties
     "transform-class-properties",
     "transform-es2015-destructuring", // https://github.com/babel/babel/issues/4074

.eslintrc

@@ -12,7 +12,7 @@
       "atom"
     ]
   },
-  "extends": ["fbjs/opensource"],
+  "extends": ["fbjs-opensource"],
   "rules": {
     "linebreak-style": 0,
     "no-param-reassign": 0,

assert-messages-plugin.js

@@ -12,6 +12,7 @@ module.exports = function({types: t}) {
         if (!t.isMemberExpression(callee)) { return; }
 
         if (!t.isIdentifier(callee.object, {name: 'assert'})) { return; }
+        if (t.isIdentifier(callee.property, {name: 'isRejected'})) { return; }
         if (!t.isIdentifier(callee.property)) { return; }
 
         try {

lib/containers/issueish-pane-item-container.js

@@ -117,10 +117,10 @@ export class IssueishPaneItemView extends React.Component {
           <div className="reactions">
             {issueish.reactionGroups.map(group => (
               group.users.totalCount > 0
-              ? <span className={cx('reaction-group', group.content.toLowerCase())} key={group.content}>
-                {reactionTypeToEmoji[group.content]} &nbsp; {group.users.totalCount}
-              </span>
-              : null
+                ? <span className={cx('reaction-group', group.content.toLowerCase())} key={group.content}>
+                  {reactionTypeToEmoji[group.content]} &nbsp; {group.users.totalCount}
+                </span>
+                : null
             ))}
           </div>
           {isPr ?

lib/containers/pr-info-container.js

@@ -143,10 +143,10 @@ export class PrInfo extends React.Component {
         <div className="reactions">
           {pr.reactionGroups.map(group => (
             group.users.totalCount > 0
-            ? <span className={cx('reaction-group', group.content.toLowerCase())} key={group.content}>
-              {reactionTypeToEmoji[group.content]} &nbsp; {group.users.totalCount}
-            </span>
-            : null
+              ? <span className={cx('reaction-group', group.content.toLowerCase())} key={group.content}>
+                {reactionTypeToEmoji[group.content]} &nbsp; {group.users.totalCount}
+              </span>
+              : null
           ))}
         </div>
         <PrStatusesContainer pullRequest={pr} />

lib/controllers/file-patch-controller.js

@@ -188,12 +188,12 @@ export default class FilePatchController extends React.Component {
       {oldMode: fp.getOldMode(), newMode: fp.getNewMode()} :
       null;
     const symlinkChange = fp && fp.hasSymlink() ?
-    {
-      oldSymlink: fp.getOldSymlink(),
-      newSymlink: fp.getNewSymlink(),
-      typechange: fp.hasTypechange(),
-      filePatchStatus: fp.getStatus(),
-    } : null;
+      {
+        oldSymlink: fp.getOldSymlink(),
+        newSymlink: fp.getNewSymlink(),
+        typechange: fp.hasTypechange(),
+        filePatchStatus: fp.getStatus(),
+      } : null;
     const repository = this.repositoryObserver.getActiveModel();
     if (repository.isUndetermined() || repository.isLoading()) {
       return (

lib/controllers/remote-pr-controller.js

@@ -53,16 +53,17 @@ export default class RemotePrController extends React.Component {
 
     return (
       <div className="github-RemotePrController">
-        {token && token !== UNAUTHENTICATED && <PrInfoController
-          {...{
-            host, remote, branches, token, loginModel, selectedPrUrl,
-            aheadCount, pushInProgress, onSelectPr, onUnpinPr,
-          }}
-          onLogin={this.handleLogin}
-          onLogout={this.handleLogout}
-          onCreatePr={this.handleCreatePr}
-                                               />
-          }
+        {token && token !== UNAUTHENTICATED &&
+          <PrInfoController
+            {...{
+              host, remote, branches, token, loginModel, selectedPrUrl,
+              aheadCount, pushInProgress, onSelectPr, onUnpinPr,
+            }}
+            onLogin={this.handleLogin}
+            onLogout={this.handleLogout}
+            onCreatePr={this.handleCreatePr}
+          />
+        }
         {(!token || token === UNAUTHENTICATED) && <GithubLoginView onLogin={this.handleLogin} />}
       </div>
     );

lib/controllers/root-controller.js

@@ -326,7 +326,7 @@ export default class RootController extends React.Component {
               discardLines={this.discardLines}
               undoLastDiscard={this.undoLastDiscard}
             />
-        )}
+          )}
         </PaneItem>
         <PaneItem workspace={this.props.workspace} uriPattern={IssueishPaneItem.uriPattern}>
           {({itemHolder, params, uri}) => (

lib/github-package.js

@@ -28,7 +28,7 @@ const defaultState = {
 
 export default class GithubPackage {
   constructor(workspace, project, commandRegistry, notificationManager, tooltips, styles, grammars, confirm, config,
-      deserializers, configDirPath, getLoadSettings) {
+    deserializers, configDirPath, getLoadSettings) {
     this.workspace = workspace;
     this.project = project;
     this.commandRegistry = commandRegistry;
@@ -322,9 +322,9 @@ export default class GithubPackage {
   createDockItemStub({uri}) {
     let item;
     switch (uri) {
-      // always return an empty stub
-      // but only set it as the active item for a tab type
-      // if it doesn't already exist
+    // always return an empty stub
+    // but only set it as the active item for a tab type
+    // if it doesn't already exist
     case 'atom-github://dock-item/git':
       item = this.createGitTabControllerStub(uri);
       this.gitTabStubItem = this.gitTabStubItem || item;

lib/helpers.js

@@ -29,7 +29,7 @@ export function getAtomHelperPath() {
     const beta = atom.appVersion.match(/-beta/);
     const appName = beta ? 'Atom Beta Helper' : 'Atom Helper';
     return path.resolve(process.resourcesPath, '..', 'Frameworks',
-     `${appName}.app`, 'Contents', 'MacOS', appName);
+      `${appName}.app`, 'Contents', 'MacOS', appName);
   } else {
     return process.execPath;
   }
@@ -126,6 +126,15 @@ export function firstImplementer(...targets) {
       }
     },
 
+    // Used by sinon
+    has(target, name) {
+      if (name === 'getImplementers') {
+        return true;
+      }
+
+      return targets.some(t => Reflect.has(t, name));
+    },
+
     // Used by sinon
     getOwnPropertyDescriptor(target, name) {
       const firstValidTarget = targets.find(t => Reflect.getOwnPropertyDescriptor(t, name));

lib/models/repository-states/present.js

@@ -609,21 +609,21 @@ export default class Present extends State {
         if (payload.upstream) {
           upstream = payload.upstream.remoteName
             ? Branch.createRemoteTracking(
-                payload.upstream.trackingRef,
-                payload.upstream.remoteName,
-                payload.upstream.remoteRef,
-              )
+              payload.upstream.trackingRef,
+              payload.upstream.remoteName,
+              payload.upstream.remoteRef,
+            )
             : new Branch(payload.upstream.trackingRef);
         }
 
         let push = nullBranch;
         if (payload.push) {
           push = payload.push.remoteName
             ? Branch.createRemoteTracking(
-                payload.push.trackingRef,
-                payload.push.remoteName,
-                payload.push.remoteRef,
-              )
+              payload.push.trackingRef,
+              payload.push.remoteName,
+              payload.push.remoteRef,
+            )
             : new Branch(payload.push.trackingRef);
         }
 

lib/views/git-tab-view.js

@@ -113,12 +113,13 @@ export default class GitTabView extends React.Component {
       );
     } else if (this.props.repository.showGitTabInit()) {
       const inProgress = this.props.repository.showGitTabInitInProgress();
-      const message = this.props.repository.hasDirectory() ?
+      const message = this.props.repository.hasDirectory()
+        ?
         (
           <span>Initialize <strong>{this.props.workingDirectoryPath}</strong> with a
           Git repository</span>
-        ) :
-          <span>Initialize a new project directory with a Git repository</span>;
+        )
+        : <span>Initialize a new project directory with a Git repository</span>;
 
       return (
         <div className="github-Panel is-empty" tabIndex="-1" ref={c => { this.refRoot = c; }}>

lib/views/staging-view.js

@@ -197,19 +197,19 @@ export default class StagingView extends React.Component {
           {this.props.hasUndoHistory ? this.renderUndoButton() : null}
           <div className="github-StagingView-list github-FilePatchListView github-StagingView-unstaged">
             {
-                this.state.unstagedChanges.map(filePatch => (
-                  <FilePatchListItemView
-                    key={filePatch.filePath}
-                    registerItemElement={this.registerItemElement}
-                    filePatch={filePatch}
-                    onDoubleClick={event => this.dblclickOnItem(event, filePatch)}
-                    onContextMenu={event => this.contextMenuOnItem(event, filePatch)}
-                    onMouseDown={event => this.mousedownOnItem(event, filePatch)}
-                    onMouseMove={event => this.mousemoveOnItem(event, filePatch)}
-                    selected={selectedItems.has(filePatch)}
-                  />
-                ))
-              }
+              this.state.unstagedChanges.map(filePatch => (
+                <FilePatchListItemView
+                  key={filePatch.filePath}
+                  registerItemElement={this.registerItemElement}
+                  filePatch={filePatch}
+                  onDoubleClick={event => this.dblclickOnItem(event, filePatch)}
+                  onContextMenu={event => this.contextMenuOnItem(event, filePatch)}
+                  onMouseDown={event => this.mousedownOnItem(event, filePatch)}
+                  onMouseMove={event => this.mousemoveOnItem(event, filePatch)}
+                  selected={selectedItems.has(filePatch)}
+                />
+              ))
+            }
           </div>
           {this.renderTruncatedMessage(this.props.unstagedChanges)}
         </div>
@@ -224,19 +224,19 @@ export default class StagingView extends React.Component {
           </header>
           <div className="github-StagingView-list github-FilePatchListView github-StagingView-staged">
             {
-                this.state.stagedChanges.map(filePatch => (
-                  <FilePatchListItemView
-                    key={filePatch.filePath}
-                    filePatch={filePatch}
-                    registerItemElement={this.registerItemElement}
-                    onDoubleClick={event => this.dblclickOnItem(event, filePatch)}
-                    onContextMenu={event => this.contextMenuOnItem(event, filePatch)}
-                    onMouseDown={event => this.mousedownOnItem(event, filePatch)}
-                    onMouseMove={event => this.mousemoveOnItem(event, filePatch)}
-                    selected={selectedItems.has(filePatch)}
-                  />
-                ))
-              }
+              this.state.stagedChanges.map(filePatch => (
+                <FilePatchListItemView
+                  key={filePatch.filePath}
+                  filePatch={filePatch}
+                  registerItemElement={this.registerItemElement}
+                  onDoubleClick={event => this.dblclickOnItem(event, filePatch)}
+                  onContextMenu={event => this.contextMenuOnItem(event, filePatch)}
+                  onMouseDown={event => this.mousedownOnItem(event, filePatch)}
+                  onMouseMove={event => this.mousemoveOnItem(event, filePatch)}
+                  selected={selectedItems.has(filePatch)}
+                />
+              ))
+            }
           </div>
           {this.renderTruncatedMessage(this.props.stagedChanges)}
         </div>

lib/worker-manager.js

@@ -260,7 +260,7 @@ Sends operations to renderer processes
 */
 export class RendererProcess {
   constructor({loadUrl,
-      onDestroyed, onCrashed, onSick, onData, onCancelled, onSpawnError, onStdinError, onExecStarted}) {
+    onDestroyed, onCrashed, onSick, onData, onCancelled, onSpawnError, onStdinError, onExecStarted}) {
     this.onDestroyed = onDestroyed;
     this.onCrashed = onCrashed;
     this.onSick = onSick;

lib/worker.js

@@ -95,22 +95,22 @@ ipc.on(channelName, (event, {type, data}) => {
 
     const spawnStart = performance.now();
     GitProcess.exec(args, workingDir, options)
-    .then(({stdout, stderr, exitCode}) => {
-      const timing = {
-        spawnTime: spawnEnd - spawnStart,
-        execTime: performance.now() - spawnEnd,
-      };
-      childPidsById.delete(id);
-      event.sender.sendTo(managerWebContentsId, channelName, {
-        sourceWebContentsId,
-        type: 'git-data',
-        data: {
-          id,
-          average: averageTracker.getAverage(),
-          results: {stdout, stderr, exitCode, timing},
-        },
+      .then(({stdout, stderr, exitCode}) => {
+        const timing = {
+          spawnTime: spawnEnd - spawnStart,
+          execTime: performance.now() - spawnEnd,
+        };
+        childPidsById.delete(id);
+        event.sender.sendTo(managerWebContentsId, channelName, {
+          sourceWebContentsId,
+          type: 'git-data',
+          data: {
+            id,
+            average: averageTracker.getAverage(),
+            results: {stdout, stderr, exitCode, timing},
+          },
+        });
       });
-    });
     const spawnEnd = performance.now();
     averageTracker.addValue(spawnEnd - spawnStart);