Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefHolder.map() should return a RefHolder #1497

Merged
merged 2 commits into from May 31, 2018

Conversation

Projects
None yet
1 participant
@smashwilson
Copy link
Member

smashwilson commented May 31, 2018

Some ambient code cleanup. It was bugging me that RefHolder looked monadic but implemented .map() inconsistently: it returned null on an empty holder but the block result when an item was present.

smashwilson added some commits May 31, 2018

@smashwilson smashwilson merged commit f7d5687 into master May 31, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@smashwilson smashwilson deleted the aw/refholder-tweaks branch May 31, 2018

smashwilson added a commit that referenced this pull request Jun 1, 2018

Merge pull request #1497 from atom/aw/refholder-tweaks
RefHolder.map() should return a RefHolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.