Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary channel names when launching Atom Helper #1579

Merged
merged 2 commits into from Jul 12, 2018

Conversation

Projects
None yet
2 participants
@daviwil
Copy link
Member

daviwil commented Jul 12, 2018

Description of the Change

This change modifies the getAtomAppName function to use a looser regex for identifying the channel name of the current Atom version. This is necessary on macOS because we will now be calling the helper app Atom Dev Helper.app during CI builds against Atom master.

Alternate Designs

Could have added dev to the existing channel name regex, but this seemed more future-proof. Happy to go back to the old approach, though.

Benefits

Less code changes to this function in the future?

Possible Drawbacks

What happens if a weird Atom build with a different version format comes along?

Applicable Issues

atom/atom#17680

@daviwil daviwil requested a review from smashwilson Jul 12, 2018

@daviwil daviwil changed the title Support arbitrary channel names when lauhching Atom Helper Support arbitrary channel names when launching Atom Helper Jul 12, 2018

@daviwil

This comment has been minimized.

Copy link
Member Author

daviwil commented Jul 12, 2018

CI seems to be failing because of the security binary config issue

@daviwil daviwil force-pushed the dw-hambetter-helper branch from 43a6e0c to 80c3d6a Jul 12, 2018

@@ -31,9 +31,10 @@ export function getPackageRoot() {
}

function getAtomAppName() {
const match = atom.getVersion().match(/beta|nightly/);
const match = atom.getVersion().match(/-([a-z]+)(\d+|-)/);

This comment has been minimized.

@smashwilson

smashwilson Jul 12, 2018

Member

No chance we'll use uppercase letters in our channel names? 😄

This comment has been minimized.

@daviwil

daviwil Jul 12, 2018

Author Member

I had it there at first but took it out because I figured it wouldn't happen. I can add it back!

@daviwil daviwil merged commit 2a25323 into 0.17-releases Jul 12, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@daviwil daviwil deleted the dw-hambetter-helper branch Jul 12, 2018

daviwil added a commit that referenced this pull request Jul 12, 2018

Merge pull request #1579 from atom/dw-hambetter-helper
Support arbitrary channel names when launching Atom Helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.