This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Support arbitrary channel names when launching Atom Helper #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviwil
changed the title
|
CI seems to be failing because of the security binary config issue |
daviwil
force-pushed
the
dw-hambetter-helper
branch
from
43a6e0c to
80c3d6a
Compare
smashwilson
approved these changes
Jul 12, 2018
lib/helpers.js
Outdated
|
|
||
| function getAtomAppName() { | ||
| const match = atom.getVersion().match(/beta|nightly/); | ||
| const match = atom.getVersion().match(/-([a-z]+)(\d+|-)/); |
There was a problem hiding this comment.
No chance we'll use uppercase letters in our channel names? 😄
There was a problem hiding this comment.
I had it there at first but took it out because I figured it wouldn't happen. I can add it back!
daviwil
added a commit
that referenced
this pull request
Jul 12, 2018
Support arbitrary channel names when launching Atom Helper
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This change modifies the
getAtomAppNamefunction to use a looser regex for identifying the channel name of the current Atom version. This is necessary on macOS because we will now be calling the helper appAtom Dev Helper.appduring CI builds against Atom master.Alternate Designs
Could have added
devto the existing channel name regex, but this seemed more future-proof. Happy to go back to the old approach, though.Benefits
Less code changes to this function in the future?
Possible Drawbacks
What happens if a weird Atom build with a different version format comes along?
Applicable Issues
atom/atom#17680