This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Make babel dependencies dev dependencies#840
Merged
BinaryMuse merged 3 commits intomasterfrom May 18, 2017
Merged
Conversation
|
@BinaryMuse could you explain why this was reverted? The commit doing has no reasoning behind it. |
Contributor
|
@Arcanemagus I don't remember the full reasoning, but all this is only relevant for packages bundled with Atom (atom/atom#14445 affects the Atom build script, not installation of third-party packages). |
|
Ah ha! Thanks for the clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the changes in atom/atom#14445 to reduce the dependencies that we bundle in our build artifacts to reduce build packaging time (which is painfully slow on Windows due to nuget and is causing timeouts). Removing babel dependencies should drop the build size by 17MB.
Ref atom/atom#14445
Ref #638