This repository was archived by the owner on Dec 15, 2022. It is now read-only.
[WIP] Stage lines from editor #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michelle Tilley <binarymuse@github.com>
|
Oh, FYI in case it wasn't clear: CI doesn't pass right now because of an annoying |
lib/common.js
Outdated
| return objects | ||
| } | ||
|
|
||
| export function any <T> (arr: Array<T>, predicate: (item: T, idx: number, arr: Array<T>) => boolean): boolean { |
There was a problem hiding this comment.
Could we use Array.prototype.some instead?
|
😻 |
lib/git-package.js
Outdated
| .map(hunk => hunk.getLines()) | ||
| .reduce((acc, lines) => acc.concat(lines), []) | ||
| .filter(line => line.isChanged() && anyRangesIntersectLine(line)) | ||
| .forEach(line => line.stage()) |
There was a problem hiding this comment.
FYI, #101 changed how staging works. You'll now need to call FileListViewModel.stageLines (and no more transacting!).
There was a problem hiding this comment.
JK, now it's GitStore.stageLines
Signed-off-by: Michelle Tilley <binarymuse@github.com>
Signed-off-by: Michelle Tilley <binarymuse@github.com>
kuychaco
force-pushed
the
ku-stage-highlighted-lines
branch
from
df7b78f to
26fcded
Compare
Signed-off-by: Michelle Tilley <binarymuse@github.com>
Signed-off-by: Michelle Tilley <binarymuse@github.com>
Signed-off-by: Michelle Tilley <binarymuse@github.com>
Signed-off-by: Michelle Tilley <binarymuse@github.com>
|
Put on hold to prioritize github-package features |
|
This is so absolutely and completely out of date that I'mma just 🔥 it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
FileDiffCloses #46