This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
as-cii
force-pushed
the
as-support-reading-snapshotted-keymaps
branch
from
b72176d to
8fe9135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will allow users to read keymaps when they were added inside the snapshot. This is part of an ongoing pull request where bundled packages are preloaded to speed up startup time.
Since we don't have access to the absolute path of the keymap file during the snapshot phase, we add keymaps and other settings as
core:node_modules/{packageName}/{resource}. Similarly to what we did on #51, with these changeskeybinding-resolverwill be able to interpret the leadingcore:node_modulesstring and load the keymap from the bundled packages metadata that ships with Atom.