Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Use black color for properties #119

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Use black color for properties #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion grammars/csharp.cson
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -983,7 +983,7 @@ repository:
}
]
"8":
name: "entity.name.variable.property.cs"
name: "variable.other.cs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does variable.property.cs also render in black?

Copy link
Contributor Author

@worldbeater worldbeater Apr 19, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fallbacks to variable.cs which is light orange while variable.property color definition is missing. I've uploaded an example here which uses variable.property key.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go with this for now.

Once users get used to the new syntax we'll look at either introducing some new elements or going more down the path other languages have done.

end: "(?<=\\})|(?=;)"
patterns: [
{
Expand Down