New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use black color for properties #119

Merged
merged 1 commit into from Apr 19, 2018

Conversation

Projects
None yet
2 participants
@worldbeater
Contributor

worldbeater commented Apr 19, 2018

Now uses black color for properties also. This is how it was before (inconsistent):

image

This is how it is after (uses black like fields, variables, params, etc.):

image

This is what I've forgotten to implement here, sorry (:
Hope this is the final tweak, and we can keep calm and wait until linguist is released.

@@ -983,7 +983,7 @@ repository:
}
]
"8":
name: "entity.name.variable.property.cs"
name: "variable.other.cs"

This comment has been minimized.

@damieng

damieng Apr 19, 2018

Contributor

Does variable.property.cs also render in black?

This comment has been minimized.

@worldbeater

worldbeater Apr 19, 2018

Contributor

It fallbacks to variable.cs which is light orange while variable.property color definition is missing. I've uploaded an example here which uses variable.property key.
image

This comment has been minimized.

@damieng

damieng Apr 19, 2018

Contributor

Okay, let's go with this for now.

Once users get used to the new syntax we'll look at either introducing some new elements or going more down the path other languages have done.

@damieng damieng merged commit d4a054e into atom:master Apr 19, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ghost

This comment has been minimized.

ghost commented May 14, 2018

@worldbeater, @damieng, is there an automatic way to update the cson from upstream https://github.com/dotnet/csharp-tmLanguage/blob/master/grammars/csharp.tmLanguage.cson and apply the patches? If no, then could we use https://github.com/dotnet/csharp-tmLanguage as a submodules and apply patches (checked in .patch files)? Then we can have a prepare script at root of this repo that applies the patch git apply patches/001-some-logical-name.patch.

@ghost

This comment has been minimized.

ghost commented May 14, 2018

I am interested in changes from dotnet/csharp-tmLanguage#117 and previous two PRs :)

@damieng

This comment has been minimized.

Contributor

damieng commented May 14, 2018

The plan was to try and get the changes applied upstream but I've had very little time to work on this since I left GitHub.

@ghost

This comment has been minimized.

ghost commented May 14, 2018

The plan was to try and get the changes applied upstream

That would be great to have single source of truth. If it breaks other tm usages upstream, maybe there we can automate it using PCRE conversion script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment