This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix improper tokenization of script tags#167
Merged
Conversation
added 2 commits
September 17, 2017 00:38
Contributor
Author
|
Ok, multiline tag handling should be back on par with master. I'll add some extra tests when I get the chance. |
Contributor
Author
|
Some syntax themes (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
#90, take two, now that I understand what clamp patterns are. Makes
styleandscripttag matching a bit saner, and fixes some incorrect scopes. In addition, overarchingmeta.tag.<tag-type>.htmlscopes have been added.Alternate Designs
Not sure yet. Just wanted to get my PR fixed before investigating if this can be improved further now that I have two years more knowledge :).- see 5c92fe4Benefits
Less wonky workarounds.
Possible Drawbacks
Just a hunch, but I believe this somewhat hurts multiline tags.- Fixed!Applicable Issues
Fixes #82
Fixes #120