New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improper tokenization of script tags #167

Merged
merged 8 commits into from Sep 17, 2017

Conversation

Projects
None yet
1 participant
@50Wliu
Member

50Wliu commented Sep 16, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

#90, take two, now that I understand what clamp patterns are. Makes style and script tag matching a bit saner, and fixes some incorrect scopes. In addition, overarching meta.tag.<tag-type>.html scopes have been added.

Alternate Designs

Not sure yet. Just wanted to get my PR fixed before investigating if this can be improved further now that I have two years more knowledge :). - see 5c92fe4

Benefits

Less wonky workarounds.

Possible Drawbacks

Just a hunch, but I believe this somewhat hurts multiline tags. - Fixed!

Applicable Issues

Fixes #82
Fixes #120

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 17, 2017

Member

Ok, multiline tag handling should be back on par with master. I'll add some extra tests when I get the chance.

Member

50Wliu commented Sep 17, 2017

Ok, multiline tag handling should be back on par with master. I'll add some extra tests when I get the chance.

@50Wliu

This comment has been minimized.

Show comment
Hide comment
@50Wliu

50Wliu Sep 17, 2017

Member

Some syntax themes (e.g. fizzy) may attempt to add .tag styling to the entirety of the embedded block due to the presence of meta.tag.script.html. This is not a problem with any of the core syntax themes. If it turns out to be a widespread problem, I will investigate reverting the new meta scopes.

Member

50Wliu commented Sep 17, 2017

Some syntax themes (e.g. fizzy) may attempt to add .tag styling to the entirety of the embedded block due to the presence of meta.tag.script.html. This is not a problem with any of the core syntax themes. If it turns out to be a widespread problem, I will investigate reverting the new meta scopes.

@50Wliu 50Wliu merged commit 4d08712 into master Sep 17, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@50Wliu 50Wliu deleted the wl-fix-script-tags branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment