This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
Contributor
Author
|
ping @50Wliu |
Contributor
Author
|
I think I am going to merge this PR. It is very low risk (only affects enums) and it is unit tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This PR extends support for enums and adds a pattern to handle enum's constant fields with method overrides. It is allowed to have such fields mixed with the previous two types that we have added.
The fix is fairly simple - adding another pattern to handle the case of enum field starting with
{and ending with}similar to inner class. For that reason, I usedinclude: #class-bodyinstead ofinclude: #code.Alternate Designs
None were considered, since it is fairly simple fix.
Benefits
Fixes enum highlighting for enums with override methods.
Possible Drawbacks
None. It only affects changes for enums.
Applicable Issues
Closes #173