This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Closed
Conversation
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Contributor
|
Does it handle the case when it is just a variable, not necessarily a class property? Can you also add a unit test that verifies the fix? Thanks. |
Contributor
Author
The issue happens only when it is a class property.
I will try. |
Contributor
|
I don't think this patch actually fixes the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com
Requirements
Description of the Change
Fixes highlighting in member-variables. For more details and examples see redhat-developer/vscode-java#707.
Alternate Designs
None were considered, since it is fairly simple fix.
Benefits
Fixes highlighting in member-variables.
Possible Drawbacks
None.
Applicable Issues
Fixes #169
Fixes #176
Fixes redhat-developer/vscode-java#707