Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Wrong highlighting in member-variables#177

Closed
snjeza wants to merge 1 commit intoatom:masterfrom
snjeza:issue-176
Closed

Wrong highlighting in member-variables#177
snjeza wants to merge 1 commit intoatom:masterfrom
snjeza:issue-176

Conversation

@snjeza
Copy link
Contributor

@snjeza snjeza commented Nov 26, 2018

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Fixes highlighting in member-variables. For more details and examples see redhat-developer/vscode-java#707.

Alternate Designs

None were considered, since it is fairly simple fix.

Benefits

Fixes highlighting in member-variables.

Possible Drawbacks

None.

Applicable Issues

Fixes #169
Fixes #176
Fixes redhat-developer/vscode-java#707

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@sadikovi
Copy link
Contributor

Does it handle the case when it is just a variable, not necessarily a class property? Can you also add a unit test that verifies the fix? Thanks.

@snjeza
Copy link
Contributor Author

snjeza commented Nov 26, 2018

Does it handle the case when it is just a variable, not necessarily a class property?

The issue happens only when it is a class property.

Can you also add a unit test that verifies the fix?

I will try.

@sadikovi
Copy link
Contributor

I don't think this patch actually fixes the issue.

@sadikovi sadikovi closed this Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong highlighting in member-variables Highlighting is wrong Highlighting is wrong

2 participants