This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Merged
Conversation
winstliu
reviewed
Jun 14, 2019
spec/java-spec.coffee
Outdated
|
|
||
| {tokens} = grammar.tokenizeLine '_1' | ||
| expect(tokens[0]).toEqual value: '_1', scopes: ['source.java'] | ||
| # TODO: Fix this test, currently it has a scope of "storage.type.java", because it starts with underscore. |
Contributor
There was a problem hiding this comment.
This is probably a valid type anyway in Java, right?
Contributor
Author
There was a problem hiding this comment.
Let me check quickly.
There was a problem hiding this comment.
It at least appears to be a valid Identifier.
Contributor
Author
There was a problem hiding this comment.
Yes, I checked, it is a valid class name. I think I am going to remove the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
I updated patterns that relate to storage types to include underscore wherever it was missing; also updated variable pattern to capture storage types with underscore.
Added unit test.
Alternate Designs
No alternative designs were considered.
Benefits
Fixes issue of having package and class names that start with underscore.
Possible Drawbacks
I had to comment out line 832 in
java-spec.coffee, "_1" value is now highlighted asstorage.type.java. I will open issue to fix this later. Should not affect anything else, as far as I am concerned.Applicable Issues
Fixes #198