This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Update scope for object properties#225
Merged
sadikovi merged 1 commit intoatom:masterfrom Apr 2, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This PR removes usage of
variable.other.property.java, replaces it withvariable.other.object.property.java.Having
variable.other.property.javadoes not make sense since there is no property call without an object/instance. This change unifies object with properties in terms of scope, see below:Before
After
The same is applicable for
object.property:Before:
After:
Alternate Designs
None were considered.
Benefits
Makes the grammar consistent, all properties get scope
variable.other.object.property.java. Allows syntax highlighting to rely on the fact that all properties will have this scope.Possible Drawbacks
Could potentially break syntax highlighting that relies on separation between trailing and non-trailing properties.
Applicable Issues
Closes #224