`true` and `false` don't get picked up inside ternary operator

[jbt]

If you type a ? true : true then the first true doesn't get picked up as a keyword, but the second does. Same if you replace it with false

It looks to me like it's seeing the colon and interpreting the first true as a label or a property name or something

[albertorestifo]

+1

Example:

[abe33]

It looks to me like it's seeing the colon and interpreting the first true as a label or a property name or something

By using the Editor: Log Cursor Scope command it appears that both ? and : are marked with the keyword.operator.js scope but the boolean between them doesn't receive any scope.

[abe33]

So here it is:
https://github.com/atom/language-javascript/blob/master/grammars/javascript.cson#L326
https://github.com/atom/language-javascript/blob/master/grammars/javascript.cson#L331

Booleans aren't highlighted if followed by :. The same issue will also appears for null, super, this, and some node-only global like process or __filename.

I thought at first that something like below could fix the issue but it cannot, as oniguruma doesn't allow for variable-length lookbehinds (see http://stackoverflow.com/questions/3479131/problem-with-quantifiers-and-look-behind):

match: '(?<!\\.)\\btrue(?!\\s*:)\\b|(?<=\\?\\s*)\\btrue(?=\\s*:)\\b'

Without the * quantifier in the look-behind the regexp is valid and match true in a ? true : false.
But having a rule for every number of space before after the ? is just insane, so I wonder what other option is available to solve this problem?
Except by creating a special keywords in ternary operator rule for each cases I listed above.

[Alhadis]

Constants aren't highlighted if followed by ternary operators, either. E.g.:

var TEXT_CONTENT = "textContent";
var HTML = document.documentElement;
TEXT_CONTENT in HTML ? TEXT_CONTENT : "innerText"

Seems to affect GitHub's JS highlighting, too.

[jbt]

👍 nice one :)