Fix tokenizing of various keywords within ternary expression

[mislav]

Supports proper tokenizing of these keywords when they appear as subexpression b within ternary expression a ? b : c:

yield, true, false, null, [CONSTANT], super, this, debugger,
module, exports, __filename, __dirname, global, process

They are not tokenized because there was a rule that these keywords should not be followed by :. This was to compensate for JS key/value syntax { foo: bar }.

The fix adds an alternate pattern for each of these keywords that explicitly allows these keywords to be followed by : if they were preceded by ?.

Fixes #93

[winstliu]

I don't think this should belong here? :P

[mislav]

Good catch, thanks

[winstliu]

I dislike how we have to add duplicate values for all these rules - I'm guessing you already tried to combine just the non-capturing rules and failed?

Also, it feels like we can add two more describes specifically for object keys and ternaries, again to avoid duplication.

[mislav]

I dislike how we have to add duplicate values for all these rules - I'm guessing you already tried to combine just the non-capturing rules and failed?

Yes, I didn't have another idea. Basically we want to disallow these keywords being tokenized as such when they're followed by :, but only if they're not preceded with ?. I'm not sure if this can be described using a simpler regular expression.

[mislav]

I've performed the desired changes.

[winstliu]

Woo! 🍧

[BrandonZacharie]

👍

[Alhadis]

Mislav, you're awesome. If I were there I'd give ya the heartiest pat-on-the-back that I could give ya. :D 👍