This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Allow regexp to immediately follow ? ternary operator
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the expression `a ? /b/ : /c/`, the first regexp wasn't recognized as such, but was tokenized as a series of operators. This fixes it by allowing regexp to immediately follow the `?` operator, not just `:`.
winstliu
pushed a commit
that referenced
this pull request
Sep 21, 2015
Allow regexp to immediately follow `?` ternary operator
|
Thanks! |
|
Thanks for the quick merge! ✨ |
mislav
added a commit
to github-linguist/linguist
that referenced
this pull request
Sep 21, 2015
This is primarily to pull atom/language-javascript#227 Full changelog: atom/language-javascript@c5c381e...7b14bbb#diff-46d5c1ca71eaebb92619d6c7abc9388d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the expression
a ? /b/ : /c/, the first regexp wasn't recognized as such, but was tokenized as a sequence of operators instead. This fixes it by allowing regexp to immediately follow the?operator.This fixes the syntax highlighting issue in Atom as well as on GitHub.com that manifests itself like this:
This is related to #93