This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Simplify single-line comment handling #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| lines = grammar.tokenizeLines ''' | ||
| import a from 'a'; // | ||
| import b from 'b'; | ||
| ''' |
Contributor
There was a problem hiding this comment.
This test doesn't cover the original issue. Corrected:
lines = grammar.tokenizeLines '''
import a from 'a' //
import b from 'b'
'''
expect(lines[1][0]).toEqual value: 'import', scopes: ['source.js', 'meta.import.js', 'keyword.control.js']
MaximSokolov
approved these changes
Jan 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Single-line comments were overcomplicated. They've been this way at least since the JSON -> CSON conversion. This PR simplifies them, in the process fixing an import bug, and also adds some basic specs for them.
Alternate Designs
None.
Benefits
Easier-to-reason-about code.
Possible Drawbacks
As far as I can tell, none.
Applicable Issues
Fixes #485.