This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add regular expression lookbehind highlighting. #554
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
The
meta.assertion.look-behind.regexp
scope was chosen so as to be consistent with the existingmeta.assertion.look-ahead.regexp
scope, though technicallymeta.assertion.lookbehind.regexp
would have been better, as the term 'lookahead' (no hyphen) is used in the ECMAScript language specification.Benefits
Enables custom syntax highlighting of regular expression lookbehind assertions.
Possible Drawbacks
There weren't previously any unit tests testing regular expression lookahead/lookbehind assertion highlighting, so there weren't any to test against.
Applicable Issues
None.