This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Inject Python string patterns into embedded SQL strings #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
atom/language-sql#70 now uses some begin/end patterns, which messes with language-python's ability to tokenize escaped characters and formatting specifiers in them. To work around that, we now inject those patterns with the highest priority when an embedded SQL string is detected.
Alternate Designs
Don't use begin/end patterns to match parentheses in language-sql.
Benefits
Backslashes in embedded SQL strings should be tokenized correctly again.
Possible Drawbacks
None?
Applicable Issues
Fixes #240
Note: needs specs, though adding specs to cover this may take effort because the existing specs are useless.