This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Call uv_async_init lazily to avoid keeping process alive.#48
Merged
kevinsawicki merged 1 commit intoatom:masterfrom Nov 21, 2014
Merged
Conversation
benjamn
force-pushed
the
issue-47-call-uv_async_init-lazily
branch
from
38af43a to
4c62a1d
Compare
benjamn
force-pushed
the
issue-47-call-uv_async_init-lazily
branch
from
4c62a1d to
c6ddf18
Compare
Contributor
|
Cool, thanks for this, I'm going to pull it and give it a spin. I'd guess that this would make it so the node-pathwatcher/Gruntfile.coffee Line 50 in 2fd0bc7 |
kevinsawicki
added a commit
that referenced
this pull request
Nov 21, 2014
Call uv_async_init lazily to avoid keeping process alive.
Contributor
|
Tested it out, thanks for fixing this 👍 🚢 |
Contributor
|
Published in |
Contributor
Author
|
Awesome, thanks for the quick turnaround! |
benjamn
added a commit
to meteor/meteor
that referenced
this pull request
Nov 22, 2014
I fixed atom/node-pathwatcher#47 with atom/node-pathwatcher#48, and @kevinsawicki published my changes to NPM as pathwatcher@2.3.3. These changes make it so pathwatcher no longer keeps our test processes alive when they would otherwise naturally exit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47.