New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to copy items by serializing and deserializing them #522

Merged
merged 1 commit into from Sep 23, 2017

Conversation

Projects
None yet
1 participant
@maxbrunsfeld
Contributor

maxbrunsfeld commented Sep 23, 2017

Fixes #234

Previously, when splitting an item using its tab's context menu, if the item did not have a .copy() method, we would try to copy the item by serializing it and then deserializing the serialized state. The problem with this is that for some items (e.g. the tree-view), deserialization always returns the same instance.

I think it's more explicit for copyable items to just implement a .copy() method. Before releasing this change, I need to add a .copy method to some of Atom's pane item classes:

@maxbrunsfeld maxbrunsfeld merged commit 37ee8a8 into master Sep 23, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@maxbrunsfeld maxbrunsfeld deleted the mb-dont-copy-by-serializing branch Sep 23, 2017

@Ben3eeE Ben3eeE referenced this pull request Jan 15, 2018

Closed

Splitting tree-view in dock creates empty pane in docks #14201

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment