This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Instruct clients not to cache /protocol-version response#47
Merged
jasonrudolph merged 1 commit intomasterfrom Mar 15, 2018
Merged
Instruct clients not to cache /protocol-version response#47jasonrudolph merged 1 commit intomasterfrom
jasonrudolph merged 1 commit intomasterfrom
Conversation
2 tasks
as-cii
approved these changes
Mar 15, 2018
Contributor
as-cii
left a comment
as-cii
left a comment
There was a problem hiding this comment.
Looks great @jasonrudolph. Thanks for looking into this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: atom/teletype#318 (comment)
With the changes in this pull request, Teletype won't cache the response that it gets from https://api.teletype.atom.io/protocol-version. Instead, Teletype will make a new request each time it needs to fetch the protocol version (i.e., each time the package is initialized).
Let's roll this out and see if it helps to address the occasional package initialization errors experienced by some users.
Supersedes #45
Refs #45 (review)