Skip to content
This repository was archived by the owner on Apr 6, 2018. It is now read-only.

Conversation

@t9md
Copy link
Contributor

@t9md t9md commented Apr 28, 2015

I added textobj paragraph feature, currently.

  • no difference for ap and ip.
  • work on multiple cursor
  • behavior on blank line is different from Vim. Vim select consecutive blank line, but this won't select any range.

@maxbrunsfeld
Copy link
Contributor

This looks good. Could you add a test for this? Let me know if you have any questions about our tests.

@t9md
Copy link
Contributor Author

t9md commented Apr 28, 2015

I only add spec for ip(inside-paragraph).
I'm not sure I should add spec for ap(around-paragraph), since currently identical behavior to ip.

@maxbrunsfeld
Copy link
Contributor

I'm not sure I should add spec for ap(around-paragraph), since currently identical behavior to ip.

I agree. The spec you added looks good. Thanks for adding this!

maxbrunsfeld pushed a commit that referenced this pull request Apr 28, 2015
@maxbrunsfeld maxbrunsfeld merged commit 14e183e into atom:master Apr 28, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
MarkusSN pushed a commit to MarkusSN/vim-mode that referenced this pull request May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants