This repository was archived by the owner on Jul 23, 2019. It is now read-only.
Conversation
Co-authored-by: Nathan Sobo <nathan@github.com>
Co-authored-by: Nathan Sobo <nathan@github.com>
Co-authored-by: Nathan Sobo <nathan@github.com>
Co-authored-by: Antonio Scandurra <as-cii@github.com>
This will allow us to move global application state into core. We want as much logic there as possible without needing to perform I/O.
I'm trying to push as much logic as possible into core that doesn't depend on specifics of the OS.
If subsequent commands are run with a different option, print an error and exit.
Co-authored-by: Nathan Sobo <nathan@github.com>
Co-authored-by: Nathan Sobo <nathan@github.com>
Co-authored-by: Antonio Scandurra <as-cii@github.com>
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
nathansobo
force-pushed
the
shared-workspaces
branch
from
4293813 to
ae07319
Compare
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
as-cii
force-pushed
the
shared-workspaces
branch
from
f85db15 to
8f4eb84
Compare
After 8f4eb84 we don't need the server to hold a reference to the buffer service anymore. Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Antonio Scandurra <as-cii@github.com>
nathansobo
force-pushed
the
shared-workspaces
branch
from
bc5f359 to
d200a70
Compare
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
as-cii
force-pushed
the
shared-workspaces
branch
from
2821eb0 to
75884ea
Compare
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
as-cii
force-pushed
the
shared-workspaces
branch
from
761eefc to
5b633f2
Compare
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
as-cii
force-pushed
the
shared-workspaces
branch
from
5b633f2 to
f44d11e
Compare
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Contributor
|
This is ready to merge once we update 002_shared_workspaces.md. |
|
FYI when trying to build this on my macbook I encounter the same error as the CI. |
Co-Authored-By: Nathan Sobo <nathan@github.com>
Co-Authored-By: Nathan Sobo <nathan@github.com>
Contributor
|
@nathansobo is going to fix the documentation in a separate pass. We are going to merge this so we can start building on top of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows multiple Xray clients to share a single remote workspace. A detailed description of the problem and architecture is included in the PR, and this will become part of this project's permanent documentation.
Tasks
--headless,--listen,--connect)