fix: improve code quality - log errors, remove non-null assertions, extract constants

[atomantic]

Better Audit — Code Quality

5 findings fixed across 5 files. Replaced silent .catch() with error logging, removed unsafe non-null assertions, extracted magic numbers to named constants.

[Copilot]

Pull request overview

Improves server-side code quality by adding error logging for previously silent failures, removing unsafe non-null assertions, and extracting repeated “magic number” cache constants into named constants.

Changes:

• Log scrape/DOM-eval failures in sync.service instead of silently swallowing errors.
• Remove non-null assertions from BFS queue handling in path.service.
• Extract cache sizing/TTL/eviction “magic numbers” into named constants across services.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
server/src/services/sync.service.ts	Adds logger usage to report scrape and result-link lookup failures.
server/src/services/path.service.ts	Replaces queue.shift()! with a safe null check to avoid non-null assertions.
server/src/services/multi-platform-comparison.service.ts	Removes an ineffective return null inside a .catch used for logging download failures.
server/src/services/id-mapping.service.ts	Extracts eviction ratio into EVICTION_RATIO constant.
server/src/services/cache.service.ts	Extracts cache size/TTL values into named constants for query/person/list caches.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Copilot]

compareAcrossProviders swallows scrapeFromProvider errors and continues, but scrapeFromProvider does not close the Puppeteer page if scrapePersonById throws (it only closes after a successful scrape). This can leak pages/tabs over time (especially in loops) and eventually destabilize the browser process. Consider updating scrapeFromProvider to close the page in a finally block (or ensure the page is closed in the error path) so failures don’t leak resources.