BrewFile support and splitting software into prompts/files#122
Merged
BrewFile support and splitting software into prompts/files#122
Conversation
…idual files and prompts
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the software installation configuration by splitting a single config into per-manager files, adds support for a project-level .BrewFile, and updates scripts and docs to load and prompt on the new files.
- Split
config.jsintosoftware/*.jsfiles for each package manager - Introduce
.BrewFilesupport for additional Homebrew packages - Update
index.js,install.sh, and documentation to load software configs dynamically
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| software/brew.js | New split file listing Homebrew CLI utilities |
| software/cask.js | New split file listing Homebrew GUI apps |
| software/npm.js | New split file listing global NPM packages |
| software/mas.js | New split file stub for Mac App Store apps |
| software/gem.js | New split file stub for Ruby gems |
| software/README.md | Doc added for each split config file |
| install.sh | Updated prompt message to reference software configuration files |
| index.js | Major refactor: dynamic imports of software/*.js, .BrewFile merge |
| homedir/.BrewFile | Sample .BrewFile for additional Homebrew packages |
| README.md | Updated top-level docs to reference the new software/ directory |
Comments suppressed due to low confidence (2)
index.js:39
- New
.BrewFileparsing and dynamic imports deserve dedicated tests to validate that additional packages are merged correctly and prompts behave as expected.
const brewFileExists = fs.existsSync("./homedir/.BrewFile");
index.js:67
- [nitpick] The
defaultproperty is not aligned undermessage, making the object literal formatting inconsistent. Re-indent for clarity and consistency.
default: false,
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #39