TypeSchema/TS: Add choice type narrowing and validation for profiles#105
Merged
TypeSchema/TS: Add choice type narrowing and validation for profiles#105
Conversation
d54f4ae to
0eeb44a
Compare
- Add narrowMergedChoiceDeclarations to restrict choice declarations to allowed variants - Add choiceRestrictions method on TypeSchemaIndex returning permitted/prohibited lists - Emit validateExcluded for disallowed choice instances in profile validation - Remove buildAllowedChoiceMap helper in favor of choiceRestrictions
0eeb44a to
936afb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
narrowMergedChoiceDeclarationsinflatProfile()to restrictChoiceFieldDeclaration.choicesto only the variants declared by the most derived constraint schemachoiceRestrictionsmethod onTypeSchemaIndexreturningRecord<string, { permitted, prohibited }>per choice groupvalidateExcludedfor disallowed choice instances in profile validationBefore (body weight
validate()allowed all 11value[x]variants):// no validation for valueString, valueBoolean, etc.After (only
valueQuantitypermitted, 10 others excluded):