TypeSchema: Refactor type system for discriminated unions and type-safe resolution#113
Merged
TypeSchema: Refactor type system for discriminated unions and type-safe resolution#113
Conversation
ryukzak
force-pushed
the
refactoring-typeschema-details
branch
from
fb3b588 to
14ba943
Compare
ryukzak
changed the title
ryukzak
force-pushed
the
refactoring-typeschema-details
branch
from
d259163 to
f297d9d
Compare
…a, LogicalTypeSchema - Export LogicalIdentifier, define three typed variants sharing RegularTypeSchemaBody - Redefine RegularTypeSchema as union alias of the three variants - Narrow type guard return types (isResourceTypeSchema, isComplexTypeTypeSchema, isLogicalTypeSchema) - Narrow collect functions in TypeSchemaIndex (collectResources, collectComplexTypes, collectLogicalModels) - Make groupByPackages generic to preserve narrowed types - Type nestedIndex as NestedType instead of TypeSchema - Use isSpecializationTypeSchema guard in TS writer instead of string array check
- Split RichFHIRSchema into RichProfileFHIRSchema (derivation: "constraint") and RichSpecializationFHIRSchema (derivation: "specialization") - Split RichSpecializationFHIRSchema into per-kind members: RichPrimitiveFHIRSchema, RichComplexTypeFHIRSchema, RichResourceFHIRSchema, RichLogicalFHIRSchema - enrichFHIRSchema normalizes derivation and kind at the boundary - mkIdentifier overloads now use named union members, enabling control-flow narrowing to resolve the correct return type - transformer branches on derivation/kind directly, removing runtime asserts that the type system now enforces
…ifier) - resolve(id: Identifier) returns TypeSchema only, no nested - resolveType(id: TypeIdentifier) returns TypeSchema | NestedTypeSchema - nestedIndex properly typed as Record<..., NestedTypeSchema> - Callers passing TypeIdentifier migrated to resolveType
ryukzak
force-pushed
the
refactoring-typeschema-details
branch
from
098c0f3 to
ddb1e6f
Compare
ryukzak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type system improvements
SpecializationTypeSchemaa proper discriminated union (ResourceTypeSchema | ComplexTypeTypeSchema | LogicalTypeSchema)RichFHIRSchemaa discriminated union on bothderivationandkindRichSpecializationFHIRSchemaintoRichPrimitiveFHIRSchema,RichComplexTypeFHIRSchema,RichResourceFHIRSchema,RichLogicalFHIRSchemamkIdentifieroverloads for each named typeTypeFamilytype,FHIRSchemaKindtype,TypeSchemaGuardInputaliasCode simplification
transformFhirSchemawith early returns instead of mutablelet typeSchemaViewModelFactoryfindLastSpecializationByIdentifierwithisNestedTypeSchemaguardType-safe resolution
resolveintoresolve(Identifier) → TypeSchemaandresolveType(TypeIdentifier) → TypeSchema | NestedTypeSchemaresolveByUrl— returnsTypeSchema | NestedTypeSchema | undefinedisNestedTypeSchemaguard for narrowing resolution resultsresolvetoresolveTypewhereTypeIdentifieris used