TS: Array setters/getters for unbounded (max: *) slices#129
Merged
Conversation
For slices with max: * (unbounded cardinality), setters now accept arrays and getters return arrays. Slices with max: 1 keep the single-element API.
a68b6a6 to
e386c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max: *(unbounded), setter accepts an array and getter returns an arraymax: 1slices, keep existing single-element API unchangedgetArraySliceAll/setArraySliceAllruntime helpers to profile-helpers.tsBefore (unbounded slice like OrganizationEntry):
After:
Closes #125