lint: promote noMisplacedAssertion to error and fix all sites#188
Merged
Conversation
Set suspicious/noMisplacedAssertion from warn to error in biome.json, then wrap every describe-scope expect() in an it() block (the rule requires assertions inside it()/test()). Touched the mustache/csharp/introspection/python/typescript writer tests and the register/ tree-shake unit tests. No behavior change — 111 tests still pass.
Base automatically changed from
python-fhirpy-default
to
python-example-decouple
June 18, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the
suspicious/noMisplacedAssertionBiome rule fromwarntoerror, and fixes every offending site somake lintstays green.Stacked on top of the python stack (base:
python-fhirpy-default/ #186).Change
biome.json:noMisplacedAssertion"warn"→"error".expect()calls that aren't inside anit()/test()block. Several suites asserted atdescribescope (setup-then-assert, or adescribebody that was really a test). Each such assertion is now wrapped in anit()(or moved out of a setup helper).32 sites across 7 files:
test/unit/typeschema/register.test.tstest/api/write-generator/introspection.test.tstest/unit/typeschema/ir/tree-shake.test.tstest/api/write-generator/python.test.tstest/api/write-generator/typescript.test.tstest/api/mustache.test.tstest/api/write-generator/csharp.test.tsNo behavior change
The assertions run exactly as before — just inside
it()blocks now. Verified:biome checkreports 0noMisplacedAssertion(and 0 errors overall), the 111 tests across the 7 files pass, andtscis clean.