Export profile base interface alongside the profile class#68
Merged
Conversation
This was problematic because e.g. MedicationActivity CCDA interface wasn’t exported, while MedicationActivityProfile class was. The fix gets all non-empty base interfaces and generated exports for them. I also tried “export * from "./profiles"”, but it seems to not work the way I expect.
ryukzak
requested changes
Feb 9, 2026
Collaborator
ryukzak
left a comment
There was a problem hiding this comment.
LGTM except comment. Also, please, fix CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing CCDA generation and writing tests for it. And I noticed that CCDA profile classes are exported, while interfaces behind them aren’t. Test snippet (added as an extra file in
examples/typescript-ccda/):it fails with
CCDA.MedicationActivitynot being found.With this PR, package
index.tshas all the necessary type exports, like