Skip to content

Conversation

@cgreening
Copy link
Contributor

Summary

Adds additional baud rates.

Motivation & Context

Closes #9

Changes

Adds more baud rates to the ConnectModal and the useSerial components.

Screenshots / Demos (if UI)

How to Test

1 Click the connect button
2 Try one of the new baud rates

Checklist

  • I ran npm run lint and fixed any issues
  • I ran npm run typecheck (TypeScript) with no errors
  • I ran npm test and tests pass
  • I ran npm run test:coverage if code paths changed significantly
  • I added/updated tests where appropriate
  • I updated docs/README if needed
  • No breaking changes without clear migration notes

Additional Notes

At some point we might want to have a free text for this field.

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
web-serial-plotter 688628b Commit Preview URL

Branch Preview URL
Sep 19 2025, 09:42 PM

@cgreening cgreening requested a review from Copilot September 19, 2025 21:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds additional lower baud rate options (300, 600, 1200, 2400, 4800) to the serial communication interface, expanding the range of supported connection speeds for legacy devices or specific hardware requirements.

  • Extends the BaudRate type definition to include 5 additional lower baud rates
  • Updates the ConnectModal component to display the new baud rate options in the UI

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/hooks/useSerial.ts Adds lower baud rates (300-4800) to the BaudRate type definition
src/components/ConnectModal.tsx Updates the BAUD_RATES array to include the new lower baud rate options

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cgreening cgreening merged commit 26b8748 into main Sep 20, 2025
7 checks passed
@cgreening cgreening deleted the feature/more-baud-rates branch September 20, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Other baudrates (1200 specifically)

2 participants