Skip to content

feat: add rn logging of native debug events#103

Merged
brax10ward merged 1 commit intomasterfrom
braxton/sdk-289-setup-debug-flag-in-react-native-sdk-for-ios
Apr 10, 2026
Merged

feat: add rn logging of native debug events#103
brax10ward merged 1 commit intomasterfrom
braxton/sdk-289-setup-debug-flag-in-react-native-sdk-for-ios

Conversation

@brax10ward
Copy link
Copy Markdown
Contributor

@brax10ward brax10ward commented Feb 2, 2026

Linear Link

https://linear.app/atomicbuilt/issue/SDK-289/setup-debug-flag-in-react-native-sdk-for-ios

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor (non-breaking change which cleans up code)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change impacts security

Checklist:

  • New and existing tests pass locally with my changes
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have tested on a physical iOS device and Android device
  • I have added tests that prove my fix is effective or that my feature works
  • I have followed the Code Review and Code Review Security guidelines
  • I have checked my code against flaws from the OWASP Top 10
    • A01:2021-Broken Access Control
    • A02:2021-Cryptographic Failures
    • A03:2021-Injection
    • A04:2021-Insecure Design
    • A05:2021-Security Misconfiguration
    • A06:2021-Vulnerable and Outdated Components
    • A07:2021-Identification and Authentication Failures
    • A08:2021-Software and Data Integrity Failures
    • A09:2021-Security Logging and Monitoring Failures
    • A10:2021-Server-Side Request Forgery

@brax10ward brax10ward force-pushed the braxton/sdk-289-setup-debug-flag-in-react-native-sdk-for-ios branch from 6ddc91c to 4b68f6a Compare April 10, 2026 18:20
@brax10ward brax10ward marked this pull request as ready for review April 10, 2026 18:20
@brax10ward brax10ward requested a review from eriksargent April 10, 2026 18:21
func presentTransact(config: [String: Any], environment: [String: Any], presentationStyle: String?, setDebug: NSNumber?, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
let debugEnabled = setDebug?.boolValue ?? false

Task { @MainActor in
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriksargent this is the biggest change that was made. Just wanted to double check that this is going to be ok to switch from DispatchQueue.main.async

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks great 👍

func presentTransact(config: [String: Any], environment: [String: Any], presentationStyle: String?, setDebug: NSNumber?, resolve: @escaping RCTPromiseResolveBlock, reject: @escaping RCTPromiseRejectBlock) -> Void {
let debugEnabled = setDebug?.boolValue ?? false

Task { @MainActor in
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks great 👍

@brax10ward brax10ward merged commit c1897d7 into master Apr 10, 2026
7 checks passed
@brax10ward brax10ward deleted the braxton/sdk-289-setup-debug-flag-in-react-native-sdk-for-ios branch April 10, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants