Adds the new assessment Component #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspencer001
reviewed
Feb 9, 2017
| this.props.editItem(itemIndex, field, data)} | ||
| addItem={() => this.props.addItem()} | ||
| /> | ||
| <div className="c-question-add"> |
Contributor
There was a problem hiding this comment.
The add button should always go at the bottom
Contributor
Author
There was a problem hiding this comment.
thats not how brandons designs have them
Contributor
Author
There was a problem hiding this comment.
it should probably disappear when the thing is open
Contributor
|
Looks good. |
BenjaminCall
pushed a commit
that referenced
this pull request
Feb 9, 2017
* Adds the new assessment Component * And a test * No box of there is a modal
BenjaminCall
added a commit
that referenced
this pull request
Feb 9, 2017
* Som tests * more specs * nav_bar_content_spec * Don't require default props * Delete assessment when button clicked * Make api calls to qbank to delete assessments * Add reducer for deleting done * Use deployed recorderjs * New assess (#119) * starting to break out the components * creates assessment * started into makeing offered * Adds new and improves styles * Rename things, extract out items a bit * Satisfy hound * Fix not building * Screwed up merge * Create and update assessments using the same component, redirect to the edit component after the api call to create the assessment completes * Adds the navbar * gets things merged right * Fix delete button selecting assessment * Add middleware and actions * Adds the new assessment Component (#120) * Adds the new assessment Component * And a test * No box of there is a modal * Get items, start creating them * Remove debugger * more specs * Create items (#123) * Get items, start creating them * Remove debugger * Create multiple choice questions * Fix specs * bad spaces
resource11
referenced
this pull request
in CLIxIndia-Dev/OpenAssessmentsClient
Feb 10, 2017
* Adds the new assessment Component * And a test * No box of there is a modal
resource11
referenced
this pull request
in CLIxIndia-Dev/OpenAssessmentsClient
Feb 10, 2017
* Som tests * more specs * nav_bar_content_spec * Don't require default props * Delete assessment when button clicked * Make api calls to qbank to delete assessments * Add reducer for deleting done * Use deployed recorderjs * New assess (#119) * starting to break out the components * creates assessment * started into makeing offered * Adds new and improves styles * Rename things, extract out items a bit * Satisfy hound * Fix not building * Screwed up merge * Create and update assessments using the same component, redirect to the edit component after the api call to create the assessment completes * Adds the navbar * gets things merged right * Fix delete button selecting assessment * Add middleware and actions * Adds the new assessment Component (#120) * Adds the new assessment Component * And a test * No box of there is a modal * Get items, start creating them * Remove debugger * more specs * Create items (#123) * Get items, start creating them * Remove debugger * Create multiple choice questions * Fix specs * bad spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code-review checklist
that code is the way it is.