Phase 7 Step 3d: thread config through 5 leaf modules (33→28 singleton audit)

[ethanj]

Summary

Phase 7 Step 3d — thread config through 5 leaf modules so they stop reading the config singleton directly. Ratchets MAX_SINGLETON_IMPORTS 33 → 28.

Supersedes closed #19 (leaf 1) and #20 (leaf 2 stacked on #19). Bundled per updated review direction (AI-reviewer flow — one-PR-per-leaf no longer needed).

Plan: atomicmemory-research/docs/core-repo/rearchitecture/phase7-v1-parity/phase7plan.md Item 3d.

The 5 leaves

Two patterns emerged based on blast radius.

Explicit parameter threading (leaves 1–3)

For leaves with few / already-threaded callers, each exported function accepts config explicitly:

Leaf	File	Callers	Pattern
1	consensus-extraction.ts	1 (memory-ingest)	consensusExtractFacts(text, config)
2	write-security.ts	6 (ingest + fact pipeline)	assessWriteSecurity(content, site, config), recordRejectedWrite(..., config, lessons?)
3	cost-telemetry.ts	4 writeCostEvent calls in llm/embedding	writeCostEvent(event, config)

Defaulting happens at the caller (composition layer already had deps.config in scope). No new infrastructure.

Module-local init (leaves 4–5)

embedding.ts and llm.ts have 15+ deep callers of their hot-path APIs (embedText, embedTexts, llm.chat). Explicit threading would be a massive ripple. Plan's pragmatism clause applies — after Step 3c provider/model selection is startup-only, so module-local state after an explicit init() call has the same semantics as the old singleton reads, just without the cross-module coupling to config.ts.

Leaf	File	Pattern
4	embedding.ts	initEmbedding(config) → module holds EmbeddingConfig; all internals call requireConfig()
5	llm.ts	initLlm(config) → module holds LLMConfig; all internals call requireConfig()

runtime-container.ts calls both inits inside createCoreRuntime, so any consumer going through the composition root is auto-initialized. Tests that bypass createCoreRuntime and call embedding / llm APIs directly must init themselves — two test files updated (embedding-cache.test.ts, llm-providers.test.ts), each now composing a narrow test config instead of mutating the config singleton.

Why the two patterns

Plan guidance: "The leaf module stops importing config entirely — that's how it drops out of config-singleton-audit.test.ts."

Both patterns satisfy that: the file no longer has import { config } from '../config.js'. The difference is where defaulting lives — at the caller (pattern 1) vs. at the composition root via init (pattern 2). Pattern 2 is defensible because (a) the ripple is prohibitive, (b) provider/model config is startup-immutable post-3c, so "rebind on init" matches reality.

Ratchet trail

After	Count	File dropped
baseline (after 3a/b/c on architecture2)	33	—
leaf 1	32	consensus-extraction.ts
leaf 2	31	write-security.ts
leaf 3	30	cost-telemetry.ts
leaf 4	29	embedding.ts
leaf 5	28	llm.ts

Per the plan, stop criterion is ~5–10 (infrastructure only — migrate.ts, index.ts, runtime-container.ts). 28 is not there yet; remaining files fall into the infra category plus a few orchestration files that are natural follow-ups for a later pass.

Test plan

• npx tsc --noEmit clean
• npm test 963/963 pass (no change in count — no new tests, just signature threading and two test files updated)
• fallow --no-cache 0 above threshold (maintainability 91.0)
• config-singleton-audit.test.ts passes at new threshold 28
• embedding-cache.test.ts and llm-providers.test.ts — now init with narrow test configs instead of mutating singleton
• Mocked test paths (smoke.test.ts, research-consumption-seams.test.ts, etc.) unaffected — their mocks replace the whole module

Commits

• 32521bc — leaf 1: consensus-extraction
• a6ad6a4 — leaf 2: write-security
• 9810334 — leaf 3: cost-telemetry
• 04aae26 — leaf 4: embedding (module-local init pattern introduced)
• 478464b — leaf 5: llm

Out of scope

• Further audit drops below 28. The plan's stop criterion is ~5–10; remaining files are infrastructure (migrate.ts, index.ts, runtime-container.ts) or orchestration files that don't benefit from threading. Separate work if pursued.
• Item 4 (retrieval polish) — 1-PR cleanup of memory-search.ts.

🤖 Generated with Claude Code