Conversation
Codex flagged that .husky/pre-commit hardcoded --base=origin/main while CI uses a dynamic base (github.base_ref || default_branch), so if the repo ever changes its default branch or a PR targets a non-default branch, the hook and CI would audit different diffs — the same false-green risk the --base pin was meant to eliminate. Replace the hardcoded ref with `git symbolic-ref --short refs/remotes/origin/HEAD`, which returns the actual default branch (origin/main, origin/staging, etc.) set by `git clone`. The hook now adapts to whatever the repo defaults to. Non-default-target PRs (a feature branch explicitly targeting staging while origin defaults to main, etc.) will still diff differently locally than CI will — that is inherent to pre-commit since the eventual PR target is not known until push time. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the earlier hook tightening. Codex flagged that
.husky/pre-commithardcoded--base=origin/main(ororigin/stagingin webapp-sdk) while CI uses a dynamic base (github.base_ref || github.event.repository.default_branch). If the repo ever changes its default branch, or a PR targets a non-default branch, the hook and CI would audit different diffs — the same false-green risk the--basepin was meant to eliminate.Fix
Replace the hardcoded ref with
git symbolic-ref --short refs/remotes/origin/HEAD, which returns the actual default branch (origin/main,origin/staging, etc.) set bygit clone. The hook now adapts to whatever the repo defaults to.Non-default-target PRs (a feature branch explicitly targeting
stagingwhile origin defaults tomain, etc.) will still diff differently locally than CI will — that is inherent to pre-commit since the eventual PR target is not known until push time. Documented inline in the hook comment.Test plan
fallow auditon this branch