Fix package-lock.json sync so npm ci succeeds in deploy#5
Merged
Conversation
The Phase 5 install used --legacy-peer-deps, which left some transitive deps (search-insights, docusaurus-plugin-sass, picomatch 2.3.2) missing from the lock. npm ci refuses to install when the lock is out of sync, so CI's 'Deploy Docs' workflow was failing on npm ci. Regenerated the lock with a clean 'rm -rf node_modules package-lock.json && npm install' (no --legacy-peer-deps needed — the peer tree is fine on its own). Verified 'npm ci' succeeds against the new lock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Deploy Docs workflow (run 24659336800) failed on `npm ci` with:
```
npm error Missing: search-insights@2.17.3 from lock file
npm error Missing: docusaurus-plugin-sass@0.2.6 from lock file
npm error Invalid: lock file's picomatch@2.3.2 does not satisfy picomatch@4.0.4
```
Cause
During the Phase 5 plugin install, `npm install --legacy-peer-deps` wrote a lock file that didn't fully resolve some transitive deps pulled in by `docusaurus-plugin-openapi-docs` / `docusaurus-theme-openapi-docs`. `npm ci` refuses to install against an out-of-sync lock.
Fix
Regenerated the lock file with a clean `rm -rf node_modules package-lock.json && npm install` (no `--legacy-peer-deps` flag — the peer tree resolves cleanly on its own). Verified `npm ci` now succeeds against the new lock locally.
Test plan