Fixes for SSL support and signing workflow#2
Merged
Merged
Conversation
Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds SSL configuration improvements and implements RPM integrated signing workflow support. The changes enable the Chelon signing service to prioritize configuration file settings over environment variables, add automatic token reloading, and introduce GPG emulation mode for embedding signatures directly into RPM headers.
- Added GPG wrapper mode to chelon-sign-rpm that emulates GPG behavior for rpmsign integration
- Enhanced SSL configuration to prioritize config file settings over environment variables with backward compatibility
- Implemented automatic token reloading in auth.py to detect new tokens without service restart
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 15 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/chelon-sign-rpm | Major enhancement adding GPG emulation mode, resign functionality for embedded signatures, and refactored detached signing |
| tools/pycache/chelon_client.cpython-314.pyc | Compiled Python bytecode file that should not be in version control |
| server/chelon-service.py | SSL configuration now prioritizes config file over environment variables with support for multiple variable names |
| server/auth.py | Added automatic token reloading when unknown tokens are encountered |
| docs/USAGE.md | Updated documentation to describe new --resign option for embedded signatures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
Signed-off-by: Scott R. Shinn <scott@atomicorp.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 11 changed files in this pull request and generated 13 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Unified 'chelon-sign-rpm' and 'chelon-sign-repomd' into 'chelon-sign' - Updated spec file to reflect tool consolidation (v1.0.0-3) - Security: Sanitized script path in RPM macros - Security: Optimized DoS protection with chunked reading - Fix: Robust error handling for base64 decoding - Fix: Improved client certificate fallback logic
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 14 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Updated docs/USAGE.md to reflect tool consolidation (chelon-sign-rpm/repomd -> chelon-sign) - Minor cleanup in auth.py (remove redundant token check) - Added specific error handling for ChelonClientError in GPG emulation mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.