Skip to content
This repository was archived by the owner on Nov 9, 2024. It is now read-only.

Conversation

@KubaJastrz
Copy link
Contributor

Missing types after d081690

Copy link
Owner

@atomiks atomiks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

What do you think about cases where users need to import the core library's animations, themes, etc? Should they just explicitly install tippy.js themselves or just use the implicit dependency path?

@KubaJastrz
Copy link
Contributor Author

KubaJastrz commented Jun 8, 2019

I think there is no reason to actually export everything from core in framework packages. You can just use the core instead. The core re-export is just a convenience more than anything, for small/unsupported cases.

The core package is installed as a dependency, so it will be always available, even if it is not present in package.json, but one can always add it if they need to have everything explicit 🤷‍♂️ (like me 😅).

@atomiks atomiks merged commit 9ef68a5 into atomiks:master Jun 8, 2019
@KubaJastrz KubaJastrz deleted the reexport-tippy branch June 8, 2019 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants