This repository was archived by the owner on Nov 9, 2024. It is now read-only.
Specify Partial<Props> in types #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubaJastrz
reviewed
Oct 1, 2019
index.d.ts
Outdated
| import {default as tippyCore, Instance, Props, Plugin} from 'tippy.js'; | ||
|
|
||
| type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>> | ||
| type Omit<T, K extends keyof T> = Pick<T, Exclude<keyof T, K>>; |
Contributor
There was a problem hiding this comment.
Omit was added in TypeScript 3.5 so we can remove it (probably need to bump the dependency)
index.d.ts
Outdated
| export const tippy: typeof tippyCore | ||
| export const tippy: typeof tippyCore; | ||
|
|
||
| export interface TippySingletonProps extends Props { |
Contributor
There was a problem hiding this comment.
Add Partial here as it is only needed for the base interface. children is still required.
Suggested change
| export interface TippySingletonProps extends Props { | |
| export interface TippySingletonProps extends Partial<Props> { |
index.d.ts
Outdated
| export const TippySingleton: React.FunctionComponent<TippySingletonProps> | ||
| export const TippySingleton: React.FunctionComponent< | ||
| Partial<TippySingletonProps> | ||
| >; |
KubaJastrz
approved these changes
Oct 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will this work @KubaJastrz